search

Adorkable / node-red-contrib-ui-led

A simple LED status indicator for the Node-RED Dashboard
MIT License
16 stars 12 forks source link

Revise to avoid peer warning messages? #73

Closed Nodi-Rubrum closed 2 years ago

Nodi-Rubrum commented 3 years ago

Revise to avoid peer warning messages? For example... npm WARN node-red-contrib-ui-led@0.4.4 requires a peer of node-red@^1.2.6 but none is installed. You must install peer dependencies yourself.

yoiang commented 3 years ago

Are you getting this when you install via the Node-RED palette?

Nodi-Rubrum commented 3 years ago

Nope, when I install via npm cli.

randomhammer commented 2 years ago

This looks similar to the error I just opened (#84) that is preventing me from installing the widget from the palette. In my case the peer it is looking for is node-red-dashboard@2.23.2.

yoiang commented 2 years ago

Hello @Nodi-Rubrum , node-red is no longer marked as a peer dependency so you should not see the message in future versions!

Hello @randomhammer , this as been resolved in PR #87, released in version 0.4.10, tracked in #86 . Please let me know there if that resolves the issue!

colinl commented 2 years ago

Unfortunately this hasn't fixed the problem. package.json still (in version 0.4.10) includes the lines

"peerDependencies": { "node-red-dashboard": "^2.23.3" },

The PR fixes it in devDependencies but not in peerDependencies