Adorkable / node-red-contrib-ui-led

A simple LED status indicator for the Node-RED Dashboard
MIT License
16 stars 12 forks source link

LED node does not handle being in a disabled group - Cannot read property config of null #80

Closed colinl closed 3 years ago

colinl commented 3 years ago

If the group containing the LED node is disabled then, on deploy, this is seen in the log

TypeError: Cannot read property 'config' of null
    at new LEDNodeConstructor (/home/colinl/.node-red/node_modules/node-red-contrib-ui-led/dist/nodes/ui_led/ui_led.js:25:44)
    at Object.createNode (/usr/lib/node_modules/node-red/node_modules/@node-red/runtime/lib/flows/util.js:86:27)
    at Flow.start (/usr/lib/node_modules/node-red/node_modules/@node-red/runtime/lib/flows/Flow.js:205:48)
    at start (/usr/lib/node_modules/node-red/node_modules/@node-red/runtime/lib/flows/index.js:371:33)

To Reproduce Steps to reproduce the behavior:

  1. Add an LED node
  2. Disable the group
  3. Deploy, watching the log

Versions

Platform

colinl commented 3 years ago

In fact this was a dashboard issue, it has been fixed in node-red-dashboard@2.30.0

yoiang commented 3 years ago

@colinl Sorry for not responding, thank you for following up!

colinl commented 3 years ago

No problem, thanks for providing the node in the first place.