search

Adoxio / xRM-Portals-Community-Edition

The definitive edition of Microsoft Open Source Portals, supported by the experts in portals.
MIT License
107 stars 60 forks source link

It appears that "shoppingCartEnabled" is set incorrectly in HeaderNavbar.ascx #113

Open MattFoy opened 5 years ago

MattFoy commented 5 years ago

https://github.com/Adoxio/xRM-Portals-Community-Edition/blob/master/Samples/MasterPortal/Views/Shared/HeaderNavbar.ascx#L16

Current line is <% var shoppingCartEnabled = string.IsNullOrEmpty(shoppingCartUrl); %> but shouldn't this be the opposite? e.g. <% var shoppingCartEnabled = !string.IsNullOrEmpty(shoppingCartUrl); %>

The logic being that is the Shopping Cart URL is present then it is enabled. The current logic is the opposite, which causes the Shopping Cart button to not be displayed.

amervitz commented 5 years ago

I am inclined to agree with you but I haven't used the functionality to confirm. If you would like to move this forward you can try modifying the logic and seeing if the cart works afterwards.

MattFoy commented 5 years ago

I flipped it and the Shopping Cart button appears, and I see the "Checkout" page. However when attempting to pay, I'm running into issues with the included Authorize.Net assembly-- Says it needs a strong name.

amervitz commented 5 years ago

I suspect the Authorize.Net assembly isn't physically present, as it isn't distributed with the project. There is also an issue (#101) with the current Authorize.Net implementation which will be a hurdle as well.

MattFoy commented 5 years ago

Yes, I know. :) I actually reported that issue.

Anyhow, I just included a copy of the source (https://github.com/AuthorizeNet/sdk-dotnet) to the solution and signed that project it with the same SNK as the MasterPortal solution which seems to have done the trick for now.

I'm currently in the process of migrating a legacy 7.0.0012 portal. Ultimately the goal is to upgrade the Authorize.Net SDK from 1.9.7 to 2.x to use a non-deprecated integration method. But for now, I just want to get the portal and CRM upgrade squared away before I tackled the ecommerce side.

amervitz commented 5 years ago

OK 😄

I would be mindful of the effort this will take as I don't think any of this functionality is supported in online portals, but I'm sure others would be happy if you were to get this working.