search

Adoxio / xRM-Portals-Community-Edition

The definitive edition of Microsoft Open Source Portals, supported by the experts in portals.
MIT License
107 stars 60 forks source link

Breadcrumbs do not display the localized page title #54

Closed slautebach closed 6 years ago

slautebach commented 6 years ago

When you define web pages with localized content (two languages), and view the page in either language, each bread crumb displays the title of the root page, not the localized page title.

amervitz commented 6 years ago

Can you please provide a screenshot?

slautebach commented 6 years ago

Here are some screen shots. The page that is being viewed, the last crumb is grabbing the title correctly (as it grabs from the current page), but the parent pages of the bread crumbs is grabbing the title of the root page, not the localized pages up the sitemap tree.

English Bread crumbs image

French Bread Crumbs: image

French Parent Page image

RicLund commented 6 years ago

I'm seeing the same behaviour.

TinoRabeGermany commented 6 years ago

+1

I have observed this behaviour as well.

amervitz commented 6 years ago

Please try the sitemap-language-fix branch to see if it fixes the issue. I will merge to master if testing goes well.

RicLund commented 6 years ago

@amervitz So the branch doesn't build for me - VS2015. Could be I'm doing something daft as I don't tend to live in Visual Studio much these days but the main branch builds fine.

builderrors

slautebach commented 6 years ago

I tested it out. Built with VS 2017, and it works for me, Thanks.

RicLund commented 6 years ago

Thanks Shawn :-/

EDIT: Use of C# 7 features is my guess at the problem here. Fantastic for those of us in environments that can move that quickly. Same as my .NETFX dependency issues.. Fun times.

amervitz commented 6 years ago

Fixed by commit https://github.com/Adoxio/xRM-Portals-Community-Edition/commit/23f13966621ef626cf884332f9d146cf6dcb5eb5.