Adoxio / xRM-Portals-Community-Edition

The definitive edition of Microsoft Open Source Portals, supported by the experts in portals.
MIT License
107 stars 60 forks source link

.NET Framework 4.7 requirement - seems to run on 4.6.2? #55

Closed RicLund closed 6 years ago

RicLund commented 6 years ago

I'm in an environment where getting to newer versions of the .NET Framework isn't trivial. Currently 4.6.2 is deployed and we've done a test portal deployment. Despite the README saying 4.7 "must be installed", the portal seems to run correctly on 4.6.2. Can someone explain what won't work or where we will hit issues? EDIT: I should add I'm connecting to 2016 (8.1) on-premise - I guess there would be issues if we were targeting Online in relation to TLS?

amervitz commented 6 years ago

The projects were upgraded to .NET 4.7 primarily for TLS 1.2 support. It's unclear how the latest code in this repository could work without .NET 4.7 installed, and it isn't predictable what the full side effects of using an older .NET version would be.

RicLund commented 6 years ago

OK. But the Microsoft-issued documentation had the requirement at 4.5 so I guess we could also say that the effects of running it on 4.7 could be unpredictable too, unless there was a full regression test performed when the change was made?

My feeling is that unless I'm targeting Online, or someone adds code that specifically uses framework features higher than 4.6.2, we should be OK.

amervitz commented 6 years ago

A full regression test was not performed. .NET 4.7 is supposed to be mostly backwards compatible with with functionality in earlier .NET versions, and any problems that are observed should be raised as issues so they can be addressed.

Using a version of .NET prior to 4.7 using the latest code would not be considered a supported scenario for the code downloaded from this repository. You may of course do so because the license allows you to do anything you want with the code, but the maintainers of this project's ability to support you would be severely limited and less likely to be a productive and successful exercise.

amervitz commented 6 years ago

Also note that .NET 4.7.1 has been released and the code will undoubtedly upgrade to it at some point in the future.

RicLund commented 6 years ago

Understood. Thanks for the help Alan.