search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
97 stars 14 forks source link

[FORGE] Crash with vampirism #38

Closed MetalKnight56 closed 1 year ago

MetalKnight56 commented 1 year ago

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2 Forge Version: 40.2.8 Nostalgic Tweaks Version: forge 2.0.0 beta 0.8.3

Describe the Bug

Game crashes everytime i right-click the Altar of Inspiration from Vampirism with a Blood Bottle

Crash Report

https://mclo.gs/2vmZkKJ

Bug Context

The game crashes, when i try to advance in vampirism, after i right click the altar of inspiration from vampirism my game crashes, that only happens if i have nostalgic tweaks enabled. I've tried playing only with the two mods and my game crashed.

Screenshots

N/A

MetalKnight56 commented 1 year ago

https://github.com/TeamLapen/Vampirism/issues/1218

forkiesassds commented 1 year ago

The mod seems to not define a fill sound at all, and it seems there is no logic to handle a potential case to handle a null sound... Whoops!

MetalKnight56 commented 1 year ago

The mod seems to not define a fill sound at all, and it seems there is no logic to handle a potential case to handle a null sound... Whoops!

I don't get it, is there anything i can do to fix this ? Or anything the vampirism developer should do to fix this issue?

Adrenix commented 1 year ago

At the moment there isn't anything you can do. I'm unsure if there is an issue the Vampirism developer needs to handle, but for me, it will be an easy fix on my end to handle any null sounds.

MetalKnight56 commented 1 year ago

Thanks for the commit, i'll await for the mod to be build to test it

Adrenix commented 1 year ago

I uploaded jars that have the commit to the project's releases. Here is the jar for Forge: https://github.com/Adrenix/Nostalgic-Tweaks/releases/download/v2.0/NostalgicTweaks-1.18.2-Forge-2.0.0-Beta-8.4-Commit-2e0e9b9.jar

MetalKnight56 commented 1 year ago

I uploaded jars that have the commit to the project's releases. Here is the jar for Forge: https://github.com/Adrenix/Nostalgic-Tweaks/releases/download/v2.0/NostalgicTweaks-1.18.2-Forge-2.0.0-Beta-8.4-Commit-2e0e9b9.jar

It fixed the issue, just tested it, and its working just fine, thanks for the help dude, I'll let you know if i find any more issues ! :)