search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
95 stars 12 forks source link

[FABRIC] and [FORGE] #61

Closed Mixces closed 3 months ago

Mixces commented 7 months ago

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.19.x - 1.20.x This issue also appears in both the Forge and Fabric versions.

Describe the Bug

Basically, the OLD_DAMAGE_ARMOR_TINT feature works well, HOWEVER, if you were to have an enchanted piece of armor on and then take damage, your armor's enchantment glint would not be showing during that moment of damage.

The Fix

I also ran into this issue while making the same feature in my mod after being inspired by Nostalgic Tweaks, and well, I actually really like Nostalgic Tweaks, so I feel very inclined to share the fix. In order to fix this, you should replace "getEntityCutoutNoCull" with "getEntityCutoutNoCullZOffset" (taken from yarn mappings). This fixed the issue for me.

Screenshots

Here are some screenshots for further proof.

In the first screenshot, the glint is clearly missing while taking damage. In the second image, the glint is visibly there whilst taking damage. no_glint yes_glint

Adrenix commented 7 months ago

Thanks for pointing that out and sharing the solution! :)

Mixces commented 7 months ago

Also sorry if this is weird, but would you mind accepting my discord friend request? We have similar passions for nostalgic Minecraft features and well I think I may be of help in your project 👀

Adrenix commented 3 months ago

Fixed in beta 9. This will eventually receive a backport fix for 1.20.1.