search

Adrenix / Nostalgic-Tweaks

This mod brings back a plethora of Minecraft Alpha/Beta gameplay elements. This mod is intended for nostalgic enthusiasts who want to relive the glory days of Minecraft by tweaking the mod to their preference.
GNU Lesser General Public License v3.0
97 stars 14 forks source link

[FABRIC] Critting doesn't work even when enabled #77

Closed Glinckey closed 4 months ago

Glinckey commented 4 months ago

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.21 Fabric Loader Version: 0.15.11 Fabric API Version: 0.100.7+1.21 Nostalgic Tweaks Version: 2.0.0-beta.901

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The crit animation and sound don't work even when the setting is enabled

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/A

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

N/A

Screenshots

If applicable, add screenshots to help explain your problem.

Adrenix commented 4 months ago

There are separate client-side tweaks that are not connected to the server-side critical hit tweak. To get the critical hit particles, turn Eye Candy > Particle Candy > Attack Particles > Disable Critical Hit Particles to No. To get the critical hit sounds, turn Sound > Damage Sounds > Disable Attack Sounds to No. Also ensure that you do not have a resource pack enabled that removes the sounds or particles.

Glinckey commented 4 months ago

Yeah, that worked, thank you! and sorry for the annoyance.

Adrenix commented 4 months ago

No worries, this was not an annoyance! I'm glad that this was just a misconfiguration and not a code issue on my part. :)