search

AdriJD / beamconv

Code library to simulate CMB detector data with realistic optics-related contributions
MIT License
10 stars 10 forks source link

expanding documentation in scanning.py #15

Closed martamonelli closed 2 years ago

martamonelli commented 2 years ago

I might have found a bug.

The input value for freq_boresight was defined as follows

freq_boresight : float
    rotation frequency of theta boresight in radians/min
    (default : 0.314)

But then, the angular frequency was calculated according to

freq_boresight = freq_boresight / 60.
omega_spin = 2. * pi * freq_boresight

In this way, the resulting angular frequency is in rad^2 per second, which doesn't make sense.

Please, check that I'm right before approving the pull request. Everything else makes sense to me.