search

AdriJD / beamconv

Code library to simulate CMB detector data with realistic optics-related contributions
MIT License
10 stars 10 forks source link

unsure about the theta, phi -> ra, dec conversion #18

Open martamonelli opened 1 year ago

martamonelli commented 1 year ago

I'm a bit confused by lines 380-387 in scanning.py: https://github.com/AdriJD/beamconv/blob/e13f52e0ccd1f370fb93e48a2b682cd984cb6246/beamconv/scanning.py#L380-L387 Shouldn't the theta, phi -> ra, dec conversion be

ra = np.degrees(phi)
dec = 90. - np.degrees(theta)

Maybe there was a reason why we wrote the conversion this way, but I cannot remember. I'm writing here just in case someone does.