search

AdriaGual / pokemon-pocket-bot

A computer vision bot made with OpenCV, OCR and ADB.
23 stars 1 forks source link

Fixed first turn and more #11

Closed NomadCHK closed 1 week ago

NomadCHK commented 1 week ago

Tested by the night and runs ok. even the double quotes on the time_limit string is ok.

please @AdriaGual test this version and lets improve it. Please add back your beautiful logs icons.

Thank youu (=

AdriaGual commented 1 week ago

@NomadCHK Gonna test this for some hours, but the code looks good!

NomadCHK commented 1 week ago

Still needs to improve end battle (need to improve wait times, time to click next, time to "thank you" button etc). Also @AdriaGual lets define a default formatting? what linter and formating you use? lets use black or ruff. We can create the standards on .vscode folder

NomadCHK commented 1 week ago

this PR may will solve #7 and #9

AdriaGual commented 1 week ago

@NomadCHK Yeah, we can go with black since it's the standard formatter for python, will merge this for now so we can close the issues and then we can focus on other improvements.

The timings is also one thing that it is taking through my nerves, but slowly we will have a version that doesn't take too long that the turn ends and at the same time it checks properly everything haha

Huge thanks with your contributions as always ❤️ 🥇