search

Adrian-Tamas / reportportal-behave-integration-client-lib

Report Portal Integration Client for Python Behave
MIT License
4 stars 4 forks source link

Added support for Report Portal attributes #4

Closed jonadaly closed 4 years ago

jonadaly commented 4 years ago

This PR adds support for Report Portal attributes, which are displayed as labels against test suite launches.

I suspect this is what the tags parameter was originally intended for, but looking at the reportportal_client library it doesn't appear to do anything: https://github.com/reportportal/client-Python/blob/master/reportportal_client/service.py#L257

I have left the tags parameter so as not to break the library, but added attributes throughout.

@Adrian-Tamas please let me know if I've misunderstood what tags were intended for!

Adrian-Tamas commented 4 years ago

@jonadaly

Originally the tags attribute I had in the library is to carry over the tags from behave if you were choosing to run your scenarios using the --tags flag but it might make sense that you would want to also add other tags to the execution.

I created this originally as a PoC for a project I worked on and decided to make it available but never ended up using the ReportPortal integration so it makes sense that I may have missed things that could be useful like attributes. Thanks for your implementation. I will keep the tags in case someone is using the tags as originally implemented.