AdrianArtiles / MediumFox

A theme for Octopress that is simple, focused, and clean. Influenced by the clean style of Medium and FoxSlide
MIT License
148 stars 45 forks source link

Italic font-style not showing #3

Open jivimberg opened 10 years ago

jivimberg commented 10 years ago

Hi there! I've noticed that using italics on markdown makes not difference on the resulting text style. Is this intentional? If not I'd be glad to help fixing the issue. For now I have workaround it by adding this to the sass/custom/_layout.scss

em {
    font-style: italic;
}

This is only a workaround of course, but I'm not really sure where to make the necessary changes for the em tag. Regards!

jivimberg commented 10 years ago

I'm seeing that this block of code is preventing the italics to be properly formatted:

html, body, div, span, applet, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, big, cite, code, del, dfn, em, img, ins, kbd, q, s, samp, small, strike, strong, sub, sup, tt, var, b, u, i, center, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, canvas, details, embed, figure, figcaption, footer, header, hgroup, menu, nav, output, ruby, section, summary, time, mark, audio, video {
    margin: 0;
    padding: 0;
    border: 0;
    font: inherit;
    font-size: 100%;
    vertical-align: baseline;
}

In particular the font directive is overshadowing the next block:

i, cite, em, var, address, dfn {
    font-style: italic;
}

Can somebody explain me where this block of code comes from (I couldn't find it in any of the other .scss files) and what is it's purpose?

Thanks!

Zettt commented 9 years ago

@jivimberg Did you find a fix for this issue? I'd love to italics too, for obvious reasons.

jivimberg commented 9 years ago

In the end I kind of hack it because I couldn't find out where that bit was coming from. Here's what I did: jivimberg/jivimberg.github.io@8c65e1a5a8807f3cc02b31dae55eae959334e8fb

Zettt commented 9 years ago

@jivimberg That's a less than ideal solution but works. Thank you very much!

alexeyza commented 9 years ago

I have a similar question - how can I make quoteblocks to be in italic font. I tried changing it (various SCSS files) and no luck (no problem in changing quoteblock font color though).