search

AdrianJSClark / aydsko-iracingdata

A .NET access library for querying the iRacing "Data" API.
MIT License
28 stars 8 forks source link

Implements /data/league/cust_league_sessions #172

Closed dennis closed 1 year ago

dennis commented 1 year ago

This is for https://github.com/AdrianJSClark/aydsko-iracingdata/issues/70

This should work (worked on a outdated main), but I'm getting the following errors:

Severity    Code    Description Project File    Line    Suppression State
Error   CP0006  Cannot add interface member 'Aydsko.iRacingData.IDataClient.GetCustomerLeagueSessionsAsync(bool, System.Nullable<int>, System.Threading.CancellationToken)' to lib/net6.0/Aydsko.iRacingData.dll because it does not exist on [Baseline] lib/net6.0/Aydsko.iRacingData.dll  Aydsko.iRacingData  C:\Program Files\dotnet\sdk\7.0.102\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets  37  
Error   CP0006  Cannot add interface member 'Aydsko.iRacingData.IDataClient.GetCustomerLeagueSessionsAsync(bool, System.Nullable<int>, System.Threading.CancellationToken)' to lib/netstandard2.0/Aydsko.iRacingData.dll because it does not exist on [Baseline] lib/netstandard2.0/Aydsko.iRacingData.dll  Aydsko.iRacingData  C:\Program Files\dotnet\sdk\7.0.102\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets  37

I might not have time tomorrow, so wanted to push it before that. If you know what the problem is, please share.

AdrianJSClark commented 1 year ago

Ah! Sorry, @dennis. I'm using .NET Package Validation and a while ago (obviously between now and your most recent contribution) I realised I wasn't looking at the output and considering it. So I switched the GenerateCompatibilitySuppressionFile property in the Aydsko.iRacingData.csproj file from true to false which raises an error on a compatibility break instead of just adding to the suppression file.

Retarget this on a local branch quickly, fix that up and get it into main now.