search

AdrianMachado / KaiUI

React component library for KaiOS apps
MIT License
187 stars 39 forks source link

adding Kaios app and removing need to update chunks in build/index.html #35

Open shishirarora3 opened 4 years ago

AdrianMachado commented 4 years ago

Can you elaborate a bit more on what this does?

patburke234 commented 4 years ago

@AdrianMachado - Looks like the main purpose is this part: INLINE_RUNTIME_CHUNK=false in the build command. The reason you need this is because for Privileged apps, inline scripts are not allowed and the default is to inject the minified chunks inline.

I've fixed this a different way using the env-cmd library and making the build environment variables have INLINE_RUNTIME_CHUNK=false inside itself.

I'd recommend we do it that way vs. react scripts rewired and all of this other jazz. I've never had much luck using that package. More trouble than it's worth.

shishirarora3 commented 4 years ago

yes, main reason is to remove inline script. also, removed cursor and add manifest.webapp

AdrianMachado commented 4 years ago

@patburke234 so we shouldn't merge this in then if you already resolved it?