search

AdrianMachado / KaiUI

React component library for KaiOS apps
MIT License
187 stars 39 forks source link

Wrap around in TabView and ListView #7

Open Phidelux opened 5 years ago

Phidelux commented 5 years ago

In ListViews moving down past the last item will jump to the first and moving up past the first jump to the last item. In TabViews this is not the case. Moving past the first and last Tab is prevented. I would expect consistent behavior and I would prefer wrapping around in both cases.

Andreas

AdrianMachado commented 5 years ago

Not sure about this one actually, the behaviour is not made clear by the spec: https://developer.kaiostech.com/design-guide/basic-navigation

iAmPriyam commented 4 years ago

I would like to contribute to the repo. Shall I work on fixing this issue?

AdrianMachado commented 4 years ago

I would like to contribute to the repo. Shall I work on fixing this issue?

Perhaps https://github.com/AdrianMachado/KaiUI/issues/22 would be a better issue, might be more useful to others!

iAmPriyam commented 4 years ago

Okay, I will start working on #22