Add Uri to string conversion

AdrianWilczynski / CSharpToTypeScript

Convert C# Models, ViewModels and DTOs into their TypeScript equivalents using webapps, CLI Tool or VSCode extension. Links: https://marketplace.visualstudio.com/items?itemName=adrianwilczynski.csharp-to-typescript - https://csharptotypescript.azurewebsites.net - https://adrianwilczynski.github.io/CSharpToTypeScript/ - https://www.nuget.org/packages/CSharpToTypeScript.CLITool/

MIT License

115 stars 32 forks source link

Add Uri to string conversion #7

Closed modesto closed 4 years ago

modesto commented 4 years ago

This pull request fixes #6

I'm not sure if I'm doing it right. should I have done it differently? :sweat_smile:

AdrianWilczynski commented 4 years ago

Hi, thanks for the pull request. You could probably just add Uri to StringConverter (there is a collection of type names there). It's gonna be simpler.

modesto commented 4 years ago

Great! I've updated the code with your suggestion.

Should the test be kept as a separate test or should I integrate it with the "ConvertBasicTypes" test?

AdrianWilczynski commented 4 years ago

It's fine either way. Thanks again! I'm gonna merge 😄