search

Adriana-Daniela / sylius-user-impersonator-plugin

0 stars 1 forks source link

Is the event name available as a constant instead of hardcoded string? #19

Closed calinpristavu closed 1 year ago

calinpristavu commented 1 year ago

In https://github.com/Adriana-Daniela/sylius-user-impersonator-plugin/blob/master/src/ContextProvider/UserImpersonatorHintContextProvider.php#LL44C16-L44C45 we hard code the template event name. Can we find it as a constant somewhere and use that?

same for the template name(but I doubt there is a constant for that)

Adriana-Capata commented 1 year ago

Unfortunately nor the event name neither the template are available as constants somewhere. They are both defined under: https://github.com/Sylius/Sylius/blob/025df951b52a1076f452c4527076a954af72957f/src/Sylius/Bundle/ShopBundle/Resources/config/app/config.yml#L633

calinpristavu commented 1 year ago

:cry: