Closed monkeygroover closed 2 years ago
Hey @monkeygroover! Thank you for taking your time to contribute to this repository!
As you may have noticed, this project is a bit outdated, and Travis CI stopped working a while ago 😅. I have pushed some changes in order to replace Travis CI with GitHub Actions. None of the affected files conflict with your PR, so just a simple rebase would most likely do the trick of getting the checks running.
I have reviewed the code and everything looks good to me. I am guessing that the changes in the other files are to resolve (deprecation) warnings. I'll approve the PR as soon as the Build and Test check passes.
I am guessing that the changes in the other files are to resolve (deprecation) warnings
yep and a couple of unused variable warnings.
Will rebase, thanks!
warning: the dependency :memoize requires Elixir "~> 1.9" but you are running on v1.6.4
i'll break the PR in two, can fix the deps warnings separately
Merging #187 (f99c366) into master (a44a071) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 23 23
Lines 1799 1799
=======================================
Hits 1723 1723
Misses 76 76
Impacted Files | Coverage Δ | |
---|---|---|
lib/commands/str_commands.ex | 92.50% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a44a071...f99c366. Read the comment docs.
See #186
~I've also fixed the compile warnings~ see #188