Closed monkeygroover closed 2 years ago
Looks like the CI infra will need bumping too for this to work?
Indeed. I just chose the same versions that were used in the old ,travis.yml file. Bumping these versions up should do the trick.
Merging #188 (931c773) into master (5bc0153) will decrease coverage by
1.24%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 95.77% 94.52% -1.25%
==========================================
Files 23 23
Lines 1799 1974 +175
==========================================
+ Hits 1723 1866 +143
- Misses 76 108 +32
Impacted Files | Coverage Δ | |
---|---|---|
lib/interp/commands/special_interp.ex | 94.28% <0.00%> (-2.54%) |
:arrow_down: |
lib/interp/interpreter.ex | 92.59% <ø> (-5.14%) |
:arrow_down: |
lib/interp/commands/binary_interp.ex | 98.87% <100.00%> (ø) |
|
lib/commands/matrix_commands.ex | 95.00% <0.00%> (-5.00%) |
:arrow_down: |
lib/interp/functions.ex | 88.77% <0.00%> (-4.49%) |
:arrow_down: |
lib/reading/input.ex | 97.14% <0.00%> (-2.86%) |
:arrow_down: |
lib/commands/list_commands.ex | 94.96% <0.00%> (-2.28%) |
:arrow_down: |
lib/commands/int_commands.ex | 96.75% <0.00%> (-2.20%) |
:arrow_down: |
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5bc0153...931c773. Read the comment docs.
Looks good to me, thanks! Dismissing the codecov checks, those are irrelevant.
not sure where is best to discuss 05ab1e stuff, so i'll just leave this here.
I'm playing around with an elixir livebooks for interactive 05ab1e experimentation, if i get anything useful working i'll post it somewhere.
also thanks for creating 05ab1e!
Fixes unused variable and deprecation warnings.
Note there are a lot of deprecations from old versions of dependencies, to fix these requires elixir 1.9+