search

Adriwin06 / Ultimate-CommonUI-Menu-System

This project provide the Ultimate Modular Menu System for Unreal Engine 5 using Common UI where everything is easy to reuse/build on. For the options menu, there is everything you need from basic scalability settings to DLSS/FSR/XeSS/NIS/TSR settings but also Post Process or Lumen settings and NvRTX settings like RTXDI or SER.
BSD 3-Clause "New" or "Revised" License
90 stars 10 forks source link

You should consider removing all code and plugins that are not related to a menu system #2

Closed codeDerleek closed 6 months ago

codeDerleek commented 6 months ago

All of the extra stuff in this repository makes it a non-starter for me to include in a project as a turnkey solution (which is what i'm looking for). There is so much that i'm planning on scanning this codebase for malware... This is not an accusation -- just feedback. If you want broader adoption you need to remove everything that is not directly related to a game menu system.

Cheers, look forward to checking this code out.

Adriwin06 commented 6 months ago

I'm sorry, but what are you talking about exactly? There are only UI-related Blueprints in this repository, and the plugins included are only Nvidia DLSS-required plugins, as well as AMD FSR and Intel XeSS Plugins. If you don't know what they are, check out the README.md. These incredible technologies are fully integrated into the Option menu, and this is one of the features that differentiates this project from others and Lyra. If you don't trust these files, just delete them and download them directly via their official website, again in the README.md. And there is absolutely no reason not to integrate these into your game, since they are already integrated into the UI, and they are awesome. But thanks you for asking here maybe I wasn't clear in the README and thanks for the interest toward my project, it really encourage me to continue when I see someone interested in it.

codeDerleek commented 6 months ago

vidia DLSS-required plugins, as well as AMD FSR and Intel XeSS Plugins.

Perhaps I am misundersanding these plugins. What do they buy you? How does this set your project apart?

It's not just these. You have the starter content added to this repository. I am quite new to unreal so perhaps I just need to see more documentation to understand why this may be here. I filed this issue when I saw a bunch of random ass files in your externalactors directory. What is that for?

Adriwin06 commented 6 months ago

The ExternalActors folder is generated by the engine. I don't have anything to do with the files inside it. For the plugins, just check out the links in the README.md, everything is explained (what do they do, how they works, etc).

codeDerleek commented 6 months ago

The ExternalActors folder is generated by the engine. I don't have anything to do with the files inside it.

Generally speaking you do not want generated files in your repository. Let your end users generate them with their own engines. What if I am using a slightly different engine version?

For the plugins, just check out the links in the README.md, everything is explained (what do they do, how they works, etc).

Right, i get what they do and how they work. I'm not clear on why these would be included in a menu system? I do not want these in my game but am open to being convinced.

Adriwin06 commented 6 months ago

1) These files are generated by the engine, but I can't delete them because they are required. With a little bit of research, I came across this post that should answer your question about these files.

2) These plugins are incredible; they boost performance and quality for free, and they don't cost anything, so why not add them? They are in the menu system because I think everyone should have them in their game, but it can be difficult to implement them all in the options menu without conflict, so I made it for them. It's not up to you to choose what the user wants, but up to them. That's why you need to add them so if they want to use one of these (especially DLSS), they can. And trust me, everyone want to use DLSS, at least DLAA if they don't want upscaling, and later when it will release, ray reconstruction, which is mind blowing).

codeDerleek commented 6 months ago

These plugins are incredible; they boost performance and quality for free, and they don't cost anything, so why not add them?

All i want is a menu system. I do not have the time or inclination to research the potential side affects of including this tech. The core of my game is established and I am not interested in introducing something like this half way through the production of my game.

I found this project through your reddit post comparing this to lyra and I think that I perhaps see why you posted this question. Is this project intended to be a starter project? as in you are coding this for users as a starting point?

If that is the case I'm afraid this project is not for me. I am looking for a menu system that functions as a drop in plugin for my own already established project.

Adriwin06 commented 6 months ago

You don't understand. There is no downside or side effect; it's just something that all games nowadays have, and it's incredible. The integration into the engine is well done and well documented; you can find a lot of tests/reviews online. How can you not know about these technologies? Everyone is talking about them. it's just a bonus/a good addition but nothing will break in your game, even if it was already 100% finished.

As for integrating this into your project, it is absolutely possible, although you will need to change a few project settings, but it's easy. I will update the Wiki and/or make a YouTube video for you to see how to do it. The sound settings will just need a little bit more, but it depends on your sound system, and it will be nothing too crazy. Hope that helps and thanks again for your interest toward my project.

codeDerleek commented 6 months ago

How can you not know about these technologies?

I am an open source web dev who is new to game development and I don't really follow the trends. I am making a brain dead simple game that is low poly and upscaling doesn't buy me anything except added complexity that I am not prepared to take on. I find it hard to believe that this type of technology is without its tradeoffs whether it be performance or complexity and I am not trying to go down that rabbit hole until I have something that would actually use this tech.

Again you are missing my point here. If this is intended as a starting point for developers including this stuff is all well and good and this entire thread is a moot point.

However, I was under the impression that this is a plugin for a game menu system in which case you should certainly avoid adding in anything that is not concerned with a game menu system.

Cheers.

Adriwin06 commented 6 months ago

Sorry I wasn't trying to be mean I was just surprised that someone didn't knew about at least DLSS, but Gamedev, tech and hardware is my world so maybe it's just me; but trust me it really doesn't have any downside and it would allow people with and even shittier PC to run your game. Anyway, I will try to update the wiki and make it as simple as possible for newcomers like you on how to integrate this in your project.

codeDerleek commented 6 months ago

You weren't being mean. I've been doing open source for quite some time and don't get riled up by text anymore.

I think I understand a bit more about why this is included here. You want your menus to include DLSS/etc in your settings. This is something that should (probably) be done without manually including the actual source code of the plugins you seek to create options for. I've never made any reusable code for unreal so I am open to being wrong.

Adriwin06 commented 6 months ago

You weren't being mean. I've been doing open source for quite some time and don't get riled up by text anymore. Thanks you. And did you lost your old Github account? Because you joined last week.

You want your menus to include DLSS/etc in your settings. Exactly

This is something that should (probably) be done without manually including the actual source code of the plugins you seek to create options for. No the source plugin is needed because it adds new nodes for changing these settings so if you don't have these plugins, you will have a ton of errors and the Blueprints won't compile.

codeDerleek commented 6 months ago

Open source exists outside of github...

Is this intended to a be a plugin or a way for users to start projects?

Adriwin06 commented 6 months ago

Is this intended to a be a plugin or a way for users to start projects?

It is intended to be something they can easily integrate in their project or a way to start a project. It's not intended to be drag and drop but almost.

Adriwin06 commented 6 months ago

I will try to do the documentation for integrating it in your project for tomorrow or after tomorrow.