Cube changes for 1.11/other changes

Adrodoc / ApertureCraftVanilla

ApertureCraft Vanilla is a command block system that implements almost all elements of the game Portal 2 in vanilla Minecraft

Other

20 stars 3 forks source link

Cube changes for 1.11/other changes #16

Closed Ersatz77 closed 7 years ago

Ersatz77 commented 7 years ago

adjusted cube_update to work in 1.11
Changed the blocks cubes can sit on from using data values to blockstates for future-proofing.
added type= selectors to improve performance.
- The more target selectors you have, the less work Minecraft needs to do to search for that entity. The performance difference is noticeable with a lot of entities
added tallgrass as a block cubes can sit on. The cubes would float above tallgrass before.
- I'm also probably going to add flowers and other plants in the future when I get around to making more textures.

SillyScientists commented 7 years ago

What is meant with the tall grass

Ersatz77 commented 7 years ago

@SillyScientists I've had issues with the cubes floating above tallgrass, and by white-listing the grass, they would properly sit on the ground and not float.

SillyScientists commented 7 years ago

@Ersatz77 do you have ideas for velovity ? Had issues with it ...

Ersatz77 commented 7 years ago

@SillyScientists I have something that does work except it's very buggy and I haven't updated it from 1.8.8. I'll probably create another pull request when I finish that and get it working again. I probably won't be done with the velocity for a while since I have other priorities, like rebuilding other parts of ACV to make it work better for my map. For example: I've added dynamic texturing of the portal backgrounds that will adapt to the blocks the portal replaces, and instead of using maps, I use models.

SillyScientists commented 7 years ago

@Ersatz77 yeah I saw this on your Channel :) Looked pretty nice ^^ I think it will easier to do this with the teleport command ^^ What do you had for ideas to save the potential gravity ?

Ersatz77 commented 7 years ago

@SillyScientists I don't know yet. I haven't touched anything related to velocity related for months. I have been updating and adding new features to my map instead. (A video should be out in a day or so that shows the new features and changes. Don't expect a 10+ minute long video, it's just a quick run-though of the first 2 test chambers with all of the updates.)

SillyScientists commented 7 years ago

@Ersatz77 Ah ok I look Forward to ask my physics teacher how to calculate the air line ^^

Adrodoc commented 7 years ago

@SillyScientists keep in mind that Minecraft does not have the same laws regarding gravity as the real world. From my experience you have to use very different values to achieve realistic/practical effects.

Adrodoc commented 7 years ago

@Ersatz77 for future pull requests it would be nice to have commit messages that actually contain information.

SillyScientists commented 7 years ago

@Adrodoc55 yeah But to put it in Minecraft you have to kniw the conditions in the real world ...

Adrodoc commented 7 years ago

@Ersatz77 Thanks again for the useful contribution.