search

AdvMaple / bilibili-subtitle-download-plugin

personal script to download subtitle from bilibili.tv (previously biliintl.com )
93 stars 25 forks source link

Add quality selection and add option to download current episode #17

Closed yoru-aniro closed 2 years ago

AdvMaple commented 2 years ago

image Bug: There isn't option for quality select

AdvMaple commented 2 years ago

image Bug: And I don't know how "Generate Links for this Ep" work. Error when press.

yoru-aniro commented 2 years ago

Seems like there're bugs when you're not login.

For Generate Links for this EP is an options for download just the current ep you're playing. It's too annoying when you want to download for just 1 ep but you have to generate for 10 or 20 eps.

yoru-aniro commented 2 years ago

@AdvMaple I just update the code. It should work well now.

AdvMaple commented 2 years ago

Generate Link for this ep doesn't work when you initialy load the series. Episode 1 of most series will not have ep_id in their URL. Here the url: image

What I console.log out: image

If you are trying to get user current episode, I suggest parsing the breadcrumb span: image

Other than that, the choose quality is working now.

yoru-aniro commented 2 years ago

Okay, I will check if it included the ep_id or not

yoru-aniro commented 2 years ago

@AdvMaple I fixed the get current issue when ep_id is not existed on pathname.

I do this by get the active class of the ep list and get the id from there.

yoru-aniro commented 2 years ago

Now the UI is supported multiple languages based on the app language (Currently EN and TH, the other will fallback to EN). You can add more translation if you wanted to.

AdvMaple commented 2 years ago

I will just revert the update url for the plugin