Advaith3600 / PowerToys-Run-Currency-Converter

PowerToys Run plugin which will convert real and crypto currencies.
MIT License
161 stars 8 forks source link

[WIP] Support for search through currency alias #12

Closed Steef-Broeder closed 4 months ago

Steef-Broeder commented 4 months ago

Uses the currency list to get all possible currencies and selects the first one that starts with what has already been typed, for both fromcurrency and tocurrency. It currently looks like this: image

A nice addition would be to show the autocompleted currency, like this: image However, I do not know how to do that.

I hope this helps, please let me know what can be improved <3

Steef-Broeder commented 4 months ago

btw, right now I'm also working on a way to automatically convert country names to currency codes which are then used.

Steef-Broeder commented 4 months ago

now country names are automatically converted to their local currency: image

Later I will also add it so that you can see the full name of the country in the Response!

Advaith3600 commented 4 months ago

Thank you for contributing to this feature! I appreciate your effort. I’d like to provide some feedback for changes:

  1. Feature Separation: It’s best to avoid adding multiple features in a single pull request (PR). Could you please remove the country code feature and submit it as a separate PR? This will help keep things organized.
  2. URL Flags: When making requests, use the @latest flags instead of hardcoding dates in the URL. This ensures that you always get the most up-to-date data.
  3. Build Issues: Unfortunately, I couldn’t test the code because the build is failing. From what I can see, it doesn’t seem to support normal conversions. Please review this aspect.
  4. Caching: To prevent excessive requests, consider implementing caching. Since conversion results don’t change rapidly, caching for 3 hours should suffice. You might want to create a new function to handle this logic.
Steef-Broeder commented 4 months ago

Thx for you feedback, I will work on it!

Steef-Broeder commented 4 months ago

I will open a new PR once I fixed the features and so that i can also make branches for them (i forgot last time)