search

Advaith3600 / PowerToys-Run-Currency-Converter

PowerToys Run plugin which will convert real and crypto currencies.
MIT License
164 stars 8 forks source link

Move local alias file to the same folder the plugin is located in #22

Open spinstartshere opened 2 days ago

spinstartshere commented 2 days ago

My documents folder is littered with folders and configuration files created by programs, and my documents folder is synchronised to my OneDrive and, therefore, to my other computers. This isn't a file that I would ever need to interact directly with myself, and it makes more sense for it to be located in the plugin's directory in %LOCALAPPDATA%\Microsoft\PowerToys\PowerToys Run\Plugins\CurrencyConverter.

Advaith3600 commented 2 days ago

Storing configuration files in the same directory as the plugin is not ideal. This arrangement poses a risk that existing configurations could be inadvertently lost during a plugin upgrade. Additionally, if the PowerToys application is reinstalled to address a different issue, all files related to this plugin may also be deleted. Therefore, it is essential to keep the configuration files in a separate location from the plugin directory.

While I understand the desire to minimize interaction with these configurations, many users appreciate the ability to customize their settings for various reasons. Unless a universally acceptable alternative location can be proposed, changing the current setup is not feasible. Moreover, implementing a customizable location is currently not possible due to the lack of support for a file picker in PowerToys Run. As a result, designating a URL as a text field is not a viable solution.

The purpose of having configuration files is to allow user-specific customization rather than being limited by a standard imposed by the plugin. Therefore, the configuration files should reside in an easily accessible location.

spinstartshere commented 2 days ago

Isn't that then the purpose of the %AppData% directory? If you want users to know where the file is, that information can be provided in the UI. Dropping a random file into your own folder in my documents folder doesn't necessarily make me more or less inclined to edit the file, especially if I can't even open it by default.

Advaith3600 commented 7 hours ago

That makes sense to me, I will wait one more week to see if someone else has an opinion about this, otherwise, I will make the migration.