Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
216 stars 273 forks source link

Request: do not register recipes that have no valid inputs (via config) #1307

Closed belathus closed 3 years ago

belathus commented 6 years ago

Version of Advanced Rocketry

1.4.0-80

Have you verified this is an issue in the latest unstable build

N

Version of LibVulpes

0.2.8-31

Version of Minecraft

1.12.2

Crash report or log (if applicable)

N/A

I made a ton of recipes for the cutting machine (here). I added forestry's wood pulp to the output of all the recipes, and now that the machine has at least one valid output. It began creating pulp from nothing. We do not have, for example, Natura installed, so no ghostwood planks or ghostwood logs, but the existence of the recipe in that file means that it makes pulp from nothing.

I've since fixed it on my end by commenting out the recipes for mods that we've removed, but it'd be nice to have some way to have those recipes automatically turn back on if I re-added Natura. I was thinking that a check for having an input array size of at least 1 before registering the recipe would work well (and possibly prevent issues like #1304), but I would also take an "IfModInstalled" tag.

belathus commented 6 years ago

... speaking of recipes with multiple outputs in the cutting machine.. it does not handle multiple outputs well. It sometimes produces more than one wood pulp if I leave the items in the output hatch. It shifts the items to the next slot, then puts the stack in another slot with more items than it should have.