Machines are eating items

[Prometheus0000]

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.4.0-91-universal

Have you verified this is an issue in the latest unstable build

Y

Version of LibVulpes

LibVulpes-1.12.2-0.2.8-34-universal

Version of Minecraft

1.12.2

Description of the problem

When you put multiple items into a machine such as the Lathe or Crystallizer, they consume the whole stack, but only produce one result, IE: 10 Steel Ingots becomes 2 Steel Rods when it should return 20. Putting in multiple types of ingots in the Lathe also results in all but one being consumed. I only tested these two machines, but it may be all the multiblock structures that take items. I tried putting the items in myself to see if it was automation related, but it still ate them. May be related to code changes in #1331?

[zmaster587]

The only change made for #1331 was to mark the inventory as updated with machines in the same way inserting an item manually has been doing. (Calling the inventory updated function in the main machine block once for every modification done via automation). The reason this needed to be updated at all is because many machine's no longer use the IInventory interface and use a capability instead in 1.12.

Can you delete the recipe xml configuration files (or back them up) before launching the game so they are regenerated new and see if the issue persists?

[Prometheus0000]

I tried moving the Lathe.xml file, but it regenerated the same, and didn't fix the problem in-game. I'm using FTB continuum 1.4.1 (I updated AR+LV and IE though). I just tested a brand new profile with just AR+LV and JEI, and it still ate a stack of Iron.

[Prometheus0000]

BTW I also noticed some other odd things. First, the the input hatches generally don't update until you deselect and reselect them. Secondly the Rolling Machine doesn't seem to need a second sheet to create the Pressure Tanks, even though JEI and the xml file says it should. I tested this on the new profile mentioned above and also tried regenerating the file too.

[dmodoomsirius]

They may have modified recipes using craft tweaker. I’ll look at that aspect when I have the moment.

Sent from my iPhone

On Jul 20, 2018, at 4:28 PM, Prometheus0000 notifications@github.com wrote:

BTW I also noticed some other odd things. First, the the input hatches generally don't update until you deselect and reselect them. Secondly the Rolling Machine doesn't seem to need a second sheet to create the Pressure Tanks, even though JEI and the xml file says it should. I tested this on the new profile mentioned above and also tried regenerating the file too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Prometheus0000]

As I mentioned, I tested it out as well on a new profile with basically just AR to check if it was that.

[zmaster587]

I can confirm the issue exists without modification to the xml files

[zmaster587]

It appears to be caused by the modification of the hatch "markdirty" function. So your hunch that it was a result of the fix for #1331 being the culprit was spot on.

[zmaster587]

The issue with the tanks only taking one sheet appears to be a misconfiguration of the default recipes file. I'll fix that too.

Instead of

<oreDict>sheetIron</oreDict>
<oreDict>sheetIron</oreDict>

it should be

<oreDict>sheetIron 2</oreDict>

[zmaster587]

Both issues should be fixed for next update of LibVulpes and AdvancedRocketry, you may need to either manually edit or regenerate the rolling machine XML file after the update.