Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
216 stars 274 forks source link

[BUG] can't put more than one gas giant in my system #1909

Closed PercyJames closed 3 years ago

PercyJames commented 4 years ago

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-232-universal

Have you verified this is an issue in the latest unstable build

[Why is this important? If you're not testing with the latest build, you may be encountering a bug that's already been fixed. Reporting bugs that have already been fixed wastes everyone's time. (please look in open issues too, somebody else could have already reported it!)]

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal

Version of Minecraft

1.12.2

Crash report or log or visualVM (if applicable)

http://pastebin.com is a good place to put them crash reports that are put in the issue itself are hard to read

https://pastebin.com/mQN8G06q

Description of the problem

i created two gas giants. one blue and one brown. one of them using a modded liquid and the other using oxygen. both have different orbit distances.

MrEyeballs29 commented 4 years ago

Gas tag doesn't exist.

Edit: Oh right

PercyJames commented 4 years ago

what?

edit: it does. on both of them.

https://pastebin.com/yPvZ2P3c

MrEyeballs29 commented 4 years ago

The gas experience doesn't exist. Check the logs.

PercyJames commented 4 years ago

ok, weird. i thought it didn't have to do with the thermal mods so that's why i put mod interaction as "no"

PercyJames commented 4 years ago

it does exist though? 2020-09-08_21 12 32

dmodoomsirius commented 4 years ago

Where does it say gas? it says fluid on that screen shot?

PercyJames commented 4 years ago

it needs to have a gas name? the wiki says "the tag consists of a fluid name from Advanced Rocketry or another mod."

PercyJames commented 4 years ago

https://pastebin.com/udkdGyYE

i gave both planets oxygen but it's still just one planet

MrEyeballs29 commented 4 years ago

Did you close off tags.

On Thu, Sep 10, 2020, 5:56 PM PercyJames notifications@github.com wrote:

https://pastebin.com/udkdGyYE

i gave both planets oxygen but it's still just one planet

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1909#issuecomment-690774257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJBRAIB3IVPAYPZ3JLTSFFKSDANCNFSM4Q3POGKQ .

PercyJames commented 4 years ago

https://pastebin.com/fzUUUbUF

is this right?

PercyJames commented 4 years ago

Did you close off tags. On Thu, Sep 10, 2020, 5:56 PM PercyJames @.***> wrote: https://pastebin.com/udkdGyYE i gave both planets oxygen but it's still just one planet — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1909 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJBRAIB3IVPAYPZ3JLTSFFKSDANCNFSM4Q3POGKQ .

https://pastebin.com/qJJWGZwH

here. i think i "closed off my tags" whatever that means. there were two spaces below the line and i removed them. but still there's just one planet.

MrEyeballs29 commented 4 years ago

Go to https://www.xmlvalidation.com/ to copy and paste your XML file. It will say what errors are.

PercyJames commented 4 years ago

i did on the entire XML and no errors were found

MrEyeballs29 commented 4 years ago

Try to set every planet "is Known" true.

On Sun, Sep 13, 2020, 12:17 PM PercyJames notifications@github.com wrote:

i did on the entire XML and no errors were found

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1909#issuecomment-691698519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJCLCJPRF5655QW5GR3SFT5BBANCNFSM4Q3POGKQ .

PercyJames commented 4 years ago

that also did not work i also just put it through the validator again and no errors were found

MrEyeballs29 commented 4 years ago

Hmm yeah, there is nothing I can do about it. Might have to have Zee Master come look at your file.

On Sun, Sep 13, 2020, 8:31 PM PercyJames notifications@github.com wrote:

that also did not work

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1909#issuecomment-691762712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJCWTCHVZO2BEXH26UTSFVXANANCNFSM4Q3POGKQ .

PercyJames commented 4 years ago

i just had an idea.

PercyJames commented 4 years ago

it didn't work

MrEyeballs29 commented 3 years ago

I think I should investigate the file.

zmaster587 commented 3 years ago

Did you close off tags. On Thu, Sep 10, 2020, 5:56 PM PercyJames @.***> wrote: https://pastebin.com/udkdGyYE i gave both planets oxygen but it's still just one planet — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1909 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJBRAIB3IVPAYPZ3JLTSFFKSDANCNFSM4Q3POGKQ .

https://pastebin.com/qJJWGZwH

here. i think i "closed off my tags" whatever that means. there were two spaces below the line and i removed them. but still there's just one planet.

Have you tried ensuring that the gas giant planets have DIMID tags? Even though AR does not generate worlds for them that you can visit (yet), the DIMID tag is still used internally by AR to differentiate worlds from each other.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity. Is this still an issue? If yes please comment that it still is.

github-actions[bot] commented 3 years ago

Please reopen this issue if you are still having what is described above. this issue has been stale for 150 days.

PercyJames commented 3 years ago

zmaster's advice worked

MrEyeballs29 commented 3 years ago

Good. Now if you have any problems go to the discord server if you have user errors. Don't use an issue tracker for any user errors for now on.

On Fri, Feb 19, 2021, 1:35 PM PercyJames notifications@github.com wrote:

zmaster's advice worked

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1909#issuecomment-782295626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJDHGSQDCRMC4OBA2I3S724QVANCNFSM4Q3POGKQ .