search

Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
216 stars 274 forks source link

[BUG] Relogging on a space ship causes planets to spin wildly in the skybox #1911

Closed aaronhowser1 closed 3 years ago

aaronhowser1 commented 4 years ago

[Please fill out the form below and delete the sections in square brackets after reading them]

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-232-universal

Have you verified this is an issue in the latest unstable build

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal

Version of Minecraft

1.12.2

Does this occur without other mods installed

Crash report or log or visualVM (if applicable)

debug.log latest.log Both are too large for pastebin, sorry

Description of the problem

If you relog while on a space ship in orbit, the planet will spin wildly. Tested by doing nothing but relogging. It doesn't get fixed by warping, or by leaving the station and coming back. Video

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity. Is this still an issue? If yes please comment that it still is.

aaronhowser1 commented 3 years ago

Yes

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity. Is this still an issue? If yes please comment that it still is.

aaronhowser1 commented 3 years ago

Yes it is. Stalebot I will stab you in the face.

MrEyeballs29 commented 3 years ago

Don't do that. It is doing its job and since due to lack of activity of the devs, the issues will not be fixed.

On Thu, Jan 7, 2021, 7:51 AM Aaron Howser notifications@github.com wrote:

Yes it is. Stalebot I will stab you in the face.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1911#issuecomment-756128348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJAXMFJH3Z2YYWUTZ3DSYW353ANCNFSM4Q6K2QWQ .

voidsong-dragonfly commented 3 years ago

AdvancedRocketry-1.12.2-1.7.0-universal.zip Here's a build with a possible fix - it's likely to reset some things to default on update but they can be interacted with to reset. Does the issue still happen wit this build?

aaronhowser1 commented 3 years ago

Nope, it works perfectly fine using that

voidsong-dragonfly commented 3 years ago

Great! I fixed some other major issues in the process too, which is nice - it turns out this was appearing as a SP bug too but in a much more.... mundane form. SP, same as MP, didn't persist states, so it just went down to min but never spun like crazy as it did for server.

aaronhowser1 commented 3 years ago

I never tried in multiplayer, all of this was in singleplayer. Glad you figured it out though!

voidsong-dragonfly commented 3 years ago

For some reason I thought it was MP then. :P Either way, the problem's fixed now (well, will be fixed once it's merged) and the area has extra sanity checking so it shouldn't be able to come up again in any form. Plus the station's now the one storing the targets and not the controller (controller still increases, though), so settings persist across controllers being broken by mistake, which is a nice bonus.

voidsong-dragonfly commented 3 years ago

Fixed in 2.0.0