Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
217 stars 273 forks source link

[BUG] only two biomes spawn #1959

Closed PercyJames closed 3 years ago

PercyJames commented 3 years ago

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-232-universal

Have you verified this is an issue in the latest unstable build

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal

Version of Minecraft

1.12.2

Does this occur without other mods installed

advanced rocketry, defiled lands, libvulpes.

Crash report or log or visualVM (if applicable)

http://pastebin.com is a good place to put them crash reports that are put in the issue itself are hard to read

https://pastebin.com/PwZiAzuF

Description of the problem

my id's for the defiled biomes are 389,388,387,385,386,384,383. but when i load the planet only the biomes in the first and the third place generate. the comma at the end doesn't seem to do anything. i checked.

MrEyeballs29 commented 3 years ago

Numerical ids are unsupported use named ids instead.

On Wed, Dec 9, 2020, 8:18 PM PercyJames notifications@github.com wrote:

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-232-universal Have you verified this is an issue in the latest unstable build

  • N/A

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal

Version of Minecraft

1.12.2

Does this occur without other mods installed

  • Y

advanced rocketry, defiled lands, libvulpes. Crash report or log or visualVM (if applicable)

http://pastebin.com is a good place to put them crash reports that are put in the issue itself are hard to read

https://pastebin.com/PwZiAzuF

Description of the problem

my id's for the defiled biomes are 389,388,387,385,386,384,383. but when i load the planet only the biomes in the first and the third place generate. the comma at the end doesn't seem to do anything. i checked.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJC7U4HFH6MVJIDT5TDSUAVXNANCNFSM4UULF5FA .

PercyJames commented 3 years ago

Ok? cause somewhere else i heard i should use numbered id's and the developer for the exoria pack uses number id's.

i'll try name id's and get back to you

PercyJames commented 3 years ago

the exact same thing happens in the exact same way with names.

MrEyeballs29 commented 3 years ago

Remove the last comma

On Wed, Dec 9, 2020, 9:31 PM PercyJames notifications@github.com wrote:

the exact same thing happens in the exact same way with names.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1959#issuecomment-742214491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJHCAXWDCXPIVWJD7E3SUA6JPANCNFSM4UULF5FA .

PercyJames commented 3 years ago

here's a pastebin https://pastebin.com/8FHNdPps in my previous number test the comma after the last number did nothing.

MrEyeballs29 commented 3 years ago

Test with the last biome with a vanilla Minecraft biome.

On Wed, Dec 9, 2020, 9:36 PM PercyJames notifications@github.com wrote:

here's a pastebin https://pastebin.com/8FHNdPps in my previous number test the comma after the last number did nothing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1959#issuecomment-742216521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJEUQYSCOYEKO7NREVDSUA623ANCNFSM4UULF5FA .

PercyJames commented 3 years ago

ok so, three biomes generated. the biomes in the first and third places and the vanilla biome. i used names for all of them

MrEyeballs29 commented 3 years ago

Now try replace all 6 of them as vanilla biomes.

On Wed, Dec 9, 2020, 10:11 PM PercyJames notifications@github.com wrote:

ok so, three biomes generated. the biomes in the first and third places and the vanilla biome. i used names for all of them

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1959#issuecomment-742226434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJDR4KUUGVAPLR2NVXTSUBC5ZANCNFSM4UULF5FA .

PercyJames commented 3 years ago

just so you know, using names is causing minecraft to crash a lot.

MrEyeballs29 commented 3 years ago

If you put invalid id's that is.

On Wed, Dec 9, 2020, 11:45 PM PercyJames notifications@github.com wrote:

just so you know, using names is causing minecraft to crash a lot.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1959#issuecomment-742255407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJBPY4CMQFJ2U7KXMOLSUBN6BANCNFSM4UULF5FA .

PercyJames commented 3 years ago

all biomes generate when vannilla.

PercyJames commented 3 years ago

how do i proceed?

voidsong-dragonfly commented 3 years ago

It sounds like you have the resource IDs wrong. Check your logs for errors.

PercyJames commented 3 years ago

logs are just gibberish of random symbols?

MrEyeballs29 commented 3 years ago

No they are used for checking errors. You might have an error in the log.

On Sat, Dec 12, 2020, 4:36 AM PercyJames notifications@github.com wrote:

logs are just gibberish of random symbols?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1959#issuecomment-743736745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJFXDWXJVPUUCIJ6ZJTSUNBT5ANCNFSM4UULF5FA .

PercyJames commented 3 years ago

ok everything is even more confusing. https://pastebin.com/6TJ5fGJk despite JITL (journey into the light) not using the id i set anywhere minecraft still thinks something is wrong with the id and JITL it happened once before and i tried to change the id but apparently something else is wrong.

PercyJames commented 3 years ago

i think i might stop trying for now. i'm gonna close the issue. i might reopen it i might not