search

Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
216 stars 274 forks source link

[Crash] same Issue with Mekanism OR JustEnoughIDs (JEIDs) #1996

Closed gatoborrachon closed 3 years ago

gatoborrachon commented 3 years ago

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-237-universal

Have you verified this is an issue in the latest unstable build

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal

Version of Minecraft

1.12.2

Does this occur without other mods installed

it happens when JustEnoughIDs OR Mekanism is present

Crash report and log, or VisualVM snapshot (if applicable)

JEIDs: https://pastebin.com/yhpPck1p Mekanism: https://pastebin.com/2ge1BN6F

Description of the problem

There's a crash when you do the following:

1.- Open (or create) a world 2.- Once it loaded, return to the main menu 3.- try to enter to the same world (i also works with any other world) 4.- See Error. (if you use VanillaFix it will simply freeze the screen, without it it will take you out)

MrEyeballs29 commented 3 years ago

I think it might be more of JEIDs issue.

On Sat, Feb 13, 2021, 6:52 PM gatoborrachon notifications@github.com wrote:

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-237-universal Have you verified this is an issue in the latest unstable build

  • Yes

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal Version of Minecraft

1.12.2 Does this occur without other mods installed

  • Yes

If Yes, what's the MINIMUM set of mods required? only JustEnoughIDs

Crash report and log, or VisualVM snapshot (if applicable)

https://pastebin.com/yhpPck1p Description of the problem

There's a crash when you do the following:

1.- Open (or create) a world 2.- Once it loaded, return to the main menu 3.- try to enter to the same world (i also works with any other world) 4.- See Error. (if you use VanillaFix it will simply freeze the screen, without it it will take you out)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJA3KAT6DEZBMADDNLTS64NGBANCNFSM4XSVUTHQ .

gatoborrachon commented 3 years ago

ok, i will try to open a new issue on their side but i think they will not do anything, you may know what is happening? (to help them)

MrEyeballs29 commented 3 years ago

Hmm. Try to remove JEIDs.

On Sat, Feb 13, 2021, 6:56 PM gatoborrachon notifications@github.com wrote:

ok, i will try to open a new issue on their side but i think they will not do anything, you may know what is happening? (to help them)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1996#issuecomment-778701615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJGI27FRUD7E4N5EQ63S64NUFANCNFSM4XSVUTHQ .

gatoborrachon commented 3 years ago

well, i use it because i exceded the limit of IDs... (removing it fixes the issue)

gatoborrachon commented 3 years ago

or you need the log with and without JEIDs?

MrEyeballs29 commented 3 years ago

Which ids are you using? Items, Blocks, Dimensions, or Biomes

On Sat, Feb 13, 2021, 7:04 PM gatoborrachon notifications@github.com wrote:

well, i use it because i exceded the limit of IDs...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1996#issuecomment-778702508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJF33BOG4NL2AVHCQODS64OQBANCNFSM4XSVUTHQ .

gatoborrachon commented 3 years ago

well, i can recreate the issue but give me a moment, it is pretty known: "java.lang.RuntimeException: Invalid id 4096 - maximum id range exceeded."

gatoborrachon commented 3 years ago

wait, wtf, i use JEIDs since i have 180+ mods because of that issue, but now i tryied to generate the same issue with 232 mods and it didn't happen again! (i removed some mods since that moment, but wtf, it was because a specific mod fault instead of having too much mods?)

well, the issue seems to be fixed for me (because i will not use JEIDs), but for anyone who uses AdvancedRocketry and JEIDs will have the same issue so nothing's fixed

gatoborrachon commented 3 years ago

I'm going to have to swallow my words, the same error has appeared again but now without JEIDs, (i need to test which mod does this but now we have another issue along this one (AR+JEIDs))

gatoborrachon commented 3 years ago

@MrEyeballs29 i found that Mekanism if the other gulty mod with the same issue (java.lang.IllegalArgumentException: Could not get provider type for dimension 0, does not exist)

should i made a new Issue or just update this one?

MrEyeballs29 commented 3 years ago

Try without AR.

On Sun, Feb 14, 2021, 8:05 AM gatoborrachon notifications@github.com wrote:

@MrEyeballs29 https://github.com/MrEyeballs29 i found that Mekanism if the other gulty mod with the same issue https://pastebin.com/2ge1BN6F (java.lang.IllegalArgumentException: Could not get provider type for dimension 0, does not exist)

should i made a new Issue or just update this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1996#issuecomment-778782581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJGF5LOONJ4QHSZKXZ3S67KCPANCNFSM4XSVUTHQ .

gatoborrachon commented 3 years ago

without Advanced Rocketry (Only Mekanism) it does not crash, so yeah, this is also a compat issue between AR and Mek, well, maybe you know that sadly Mekanism 1.12 is dead for the authors, is this possible to be fixed from AR's Side?

gatoborrachon commented 3 years ago

i want to add that i use OpenJ9 by performance reasons, but i confirmed that this issue also happens with the default JVM (HotSpot)

MrEyeballs29 commented 3 years ago

Let me see if I can reproduce the issue.

On Sun, Feb 14, 2021, 8:30 AM gatoborrachon notifications@github.com wrote:

i want to add that i use OpenJ9 by performance reasons, but i confirmed that this issue https://pastebin.com/JBEqp1Gm also happens with the default JVM (HotSpot)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1996#issuecomment-778785769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJF6GFIWYSPXCAZ2HW3S67NAFANCNFSM4XSVUTHQ .

gatoborrachon commented 3 years ago

yeah, please test it, i wish it is possible to fix from AR's side, as i said, Mekanism will not recieve an update by their authors (or if it's an easy fix in Mekanism's side, i can do it myself, just tell me exactly what i need to do)

and take your time, no worries

MrEyeballs29 commented 3 years ago

I cannot reproduce the issue. My end my game doesn't have any crashes related to mekanism or AR. https://pastebin.com/4viMTahh https://pastebin.com/TFhiT8G9

That might be your end. I even used the same mods and no issue. You might be using an outdated version of AR.

gatoborrachon commented 3 years ago

You might be using an outdated version of AR.

But i use AdvancedRocketry-1.12.2-1.7.0-235-universal (the latest according to CurseForge)

That might be your end. I even used the same mods and no issue.

well, i really have no idea what may be happening, i used HotSpot to confirm this is not an issue related to OpenJ9 and i only used these 2 mods so it's impossible to be the fault of any other mod, is there a way to know what's different in our computers? that VisualVM snapshot should tell us what is happening? (sorry for late reply)

MrEyeballs29 commented 3 years ago

No the latest is actually build 237.

On Sun, Feb 14, 2021, 7:50 PM gatoborrachon notifications@github.com wrote:

You might be using an outdated version of AR.

But i use AdvancedRocketry-1.12.2-1.7.0-235-universal (the latest according to CurseForge)

That might be your end. I even used the same mods and no issue.

well, i really have no idea what may be happening, i used HotSpot to confirm this is not an issue related to OpenJ9 and i only used these 2 mods so it's impossible to be the fault of any other mod, is there a way to know what's different in our computers? that VisualVM snapshot should tell us what is happening? (sorry for late reply)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zmaster587/AdvancedRocketry/issues/1996#issuecomment-778890023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGVDBJCQJTLVQRDQ77O2BGTS7B4XXANCNFSM4XSVUTHQ .

voidsong-dragonfly commented 3 years ago

Backing up a step. I think this is neither of those mods' issues. I think your planetDefs.xml got corrupted somehow. DIM0 not having a provider is pretty serious. Best guess is you have a DIMID="0" without a DIMMAPPING="" tag for your overworld planet. Can you verify this for me?

gatoborrachon commented 3 years ago

Can you verify this for me?

@MrEyeballs29 @Silfryi well, i think that was the issue, i copied one of the examples on PlanetDefs-Sharing and modified somethings, except that one, many thanks for all

but now what exactly i need to put in my planet earth? 1.- DIMID="0" DIMMAPPING="0" OR 2.- DIMID="0" DIMMAPPING=""

gatoborrachon commented 3 years ago

well, i just need to try it by myself, many thanks again

MrEyeballs29 commented 3 years ago

That is not a bug but a user error.