Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
216 stars 274 forks source link

Crash on server Ticking entity from enchantment 1.16.5 #2022

Closed IchigoGames closed 3 years ago

IchigoGames commented 3 years ago

Version of Advanced Rocketry

AdvancedRocketry-1.16.5-1.7.1-4-universal.jar

Have you verified this is an issue in the latest unstable build

Version of LibVulpes

LibVulpes-1.16.5-1.0.1-6-universal.jar

Version of Minecraft

Does this occur without other mods installed

Crash report and log, or VisualVM snapshot (if applicable)

https://pastebin.com/fPFuWu9S

Description of the problem

Crash on server from java.lang.NoSuchMethodError: net.minecraft..Enchantment.func_185262_c(I)Lnet/minecraft/enchantment/Enchantment; at zmaster587.advancedRocketry.util.ItemAirUtils.isStackValidAirContainer(ItemAirUtils.java:127) ~[advancedrocketry:unspecified] was not on server at the time so im not sure what enchantment caused it

Forge 36.1.2 Minecraft 1.16.5 Modpack The Final Frontier 2 5.5

IchigoGames commented 3 years ago

let me know if anyone other info is need

IchigoGames commented 3 years ago

image looks like theres only one enchantment that it could be as its the only one this mod adds

IchigoGames commented 3 years ago

could be a conflict with the Apotheosis mod as it allows for enchments that are way more powerfull then normal aka lvl 40+ enchants

zmaster587 commented 3 years ago

It's possible, before build 5 of AR and 8 of libvulpes, I was also targetting an earlier version of forge, could you check to see if it's still a problem with the latest build?

IchigoGames commented 3 years ago

ill try to test it its a hard one to test tho as im not 100% how it happened no one had the enchant yet but it still show that as the reason for crash would need to put it back on server to test it and i think its too soon for that. will try and recreate it in single player.

zmaster587 commented 3 years ago

I looked at it a bit more today, I think it might be server-side only, so if you cannot replicate the crash in single player, then I think I got the problem nailed down.

zmaster587 commented 3 years ago

Dupe of #2017 should be fixed for the next update