search

Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
216 stars 274 forks source link

[1.12.2] crash and corruption of world when teleporting to wrong coordinates on space station dimension #2023

Closed Alessandro404 closed 3 years ago

Alessandro404 commented 3 years ago

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-1.7.0-240-universal

Have you verified this is an issue in the latest unstable build

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-75-universal

Version of Minecraft

1.12.2

Does this occur without other mods installed

Crash report and log, or VisualVM snapshot (if applicable)

https://pastebin.com/B2n0iWtT

Description of the problem

This crash was with my modpack because I used a mod item for changing coordinates and teleporting around. My guess is, in places where there is not a generated space station, the mod cannot understand what kind of sun brightness there is and crashes. Maybe add a fallback? This was not a problem in earlier version of the mod.

voidsong-dragonfly commented 3 years ago

AdvancedRocketry-1.12.2-1.7.0-universal.jar.zip Does this LibVulpes + AR combination work for you? Be warned that it will break some multiblocks, and you will NEED to make a backup if you want to use it in a survival world if you want to downgrade. LibVulpes-1.12.2-0.4.2-universal.jar.zip

Alessandro404 commented 3 years ago

Now the game kicks me out of the dimension if none has been created correctly. Also, with a built structure but in a wrong coordinate, the game now places you in the "center" of the space dimension. I guess its a safe spot? It seems to be working good.

voidsong-dragonfly commented 3 years ago

Yes, it kicks you out of the dimension without any stations to send you to. Otherwise it sends you to the spawn point of the station (the same place you spawn if you fall out of the world in a space station dimension).

Alessandro404 commented 3 years ago

Will this version that you gave me be upgradeable to the next curse forge version?

voidsong-dragonfly commented 3 years ago

Yes, it will be. It's essentially the next CF version, probably minus a few fixes.

Alessandro404 commented 3 years ago

Thank you for fixing this bug and for your help!