Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
217 stars 273 forks source link

[BUG] Mod breaks world data #2230

Open WithoutAName25 opened 2 years ago

WithoutAName25 commented 2 years ago

Version of Advanced Rocketry

1.16.5-2.0.0-16

Have you verified this is an issue in the latest unstable build

Version of LibVulpes

1.16.5-1.0.2-27

Version of Minecraft

1.16.5

Does this occur without other mods installed

Crash report or log or visualVM (if applicable)

debug.log latest.log

Description of the problem

  • Create a new singleplayer world
  • Leave the world
  • The world will not show up in the singleplayer-world-list
  • Restart the client
  • The world will show up in the list
  • Try to load the world
  • You will get the message "Errors in currently selected datapacks prevented the world from loading.\n You can either try to load it with only the vanilla data pack ("save mode"), or go back to the title screen and fix it manually." You have the options "Save Mode" and "Back to Title Screen".
WithoutAName25 commented 2 years ago

I have tested it with AdvancedRocketry-1.16.5-2.0.0-12, there everything was fine

Art1xs commented 2 years ago

Having the same problem!

HockeyZman2000 commented 2 years ago

A temporary fix for this is deleting the "ar_datapack" inside of your world's save folder before loading the world. To join back again after you leave you'll have to delete it again.

Art1xs commented 2 years ago

damn, Thats harsh. I just went back to using 1.16.5-2.0.0-12 and it seems to be working fine

dave75vgnut commented 2 years ago

Have same issue, but I just delete "pack.mcmeta" file inside the "ar_datapack" folder then it loads fine have to do this each time I want to load save thou.

TehFoxFire commented 2 years ago

Having same issue on 2.0.0-16

TelepathicGrunt commented 2 years ago

Someone else was having this issue so I modified Blame temporarily to see what exactly was dying. It seems to be the Luna dimension image

Perhaps this will help narrow down the exact cause. If advanced rocketry is creating the dimension by code, I would strongly suggest to not do that lol. It causes issues and has lots of possible edge cases like this. Dimensions should always be made by json files instead

CrimsonNode commented 2 years ago

Have the exact issue.

KingOfMiners commented 2 years ago

Doing some digging myself, it looks like the issue is from all the JSON files being completely empty, so when the game goes to actually parse the data, it gets null, rather than an empty JSON tag.