[BUG] Item texture missing when install with certain mods, cause by registering at wrong event - Githubissues

Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft

http://arwiki.dmodoomsirius.me/

MIT License

215 stars 273 forks source link

[BUG] Item texture missing when install with certain mods, cause by registering at wrong event #2304

Closed kappa-maintainer closed 2 years ago

kappa-maintainer commented 2 years ago

Version of Advanced Rocketry

1.12.2-2.0.0-257 build -257 for 1.12.2

Have you verified this is an issue in the latest unstable build

[x] Y
[ ] N
[ ] N/A

Version of LibVulpes

1.12.2-0.4.2-88 build -88 for 1.12.2

Version of Minecraft

1.12.2

Does this occur without other mods installed

[ ] Y
[x] N
[ ] N/A

Crash report or log or visualVM (if applicable)

No crash

Description of the problem

Install Advanced Rocketry with the latest Double Slabs or Grappling Hook Mod, launch the game, all blocks registered through LibVulpesBlocks.registerBlock will have a black & purple checkerboards model. This is because https://github.com/Advanced-Rocketry/libVulpes/blob/2c0231c5d821e2901459401a21dd253c6759821c/src/main/java/zmaster587/libVulpes/api/LibVulpesBlocks.java#L85 was executing at block register event, not model register event.

voidsong-dragonfly commented 2 years ago

1.12 is no longer supported via code changes