Advanced-Rocketry / AdvancedRocketry

Space mod for minecraft
http://arwiki.dmodoomsirius.me/
MIT License
215 stars 273 forks source link

[BUG] biome remote crash potential fix #2393

Closed dercodeKoenig closed 1 month ago

dercodeKoenig commented 1 month ago

nullpointer exception when rendering: crash when mouse over biome remote that has no biome set

potential fix: in advancedRocketry/satellite/SatelliteBiomeChanger.java the biomeId is not initialized. when setbiome is not called there will be a nullpointer error in advancedRocketry/item/ItemBiomeChanger.java:81

this is exactly what happens. when satelite is launched and no biome is set, nullpointer exception when mouse over biome remote

there needs to be a default value and in ItemBiomeChanger there needs to be checked if a biome is selected before it displays the selected biome

dercodeKoenig commented 1 month ago

fixed in https://github.com/StannisMod/AdvancedRocketry/pull/1