search

AdvancedClimateSystems / uModbus

Python implementation of the Modbus protocol.
Mozilla Public License 2.0
211 stars 81 forks source link

Allow omitted rule constraints to match any value #101

Closed rgov closed 4 years ago

rgov commented 4 years ago

The definition of umodbus.server.route gives default values of None to the arguments, suggesting they can be omitted. However, if you actually provide None, it will fail later when evaluating DataRule.match.

This change makes it possible to omit any rule constraint to match on any value.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.005%) to 95.857% when pulling 5dc1dbe8d056b717c2526e22bdcf56f74542a49a on rgov:rzg/optional-args into dcf35a1f9881d0d5ffa4a640d1242fdcb3491bd7 on AdvancedClimateSystems:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.005%) to 95.857% when pulling 3937df23573de10b49746fa4371771c5ed14d52b on rgov:rzg/optional-args into dcf35a1f9881d0d5ffa4a640d1242fdcb3491bd7 on AdvancedClimateSystems:master.