AdvancedCustomFields / acf

Advanced Custom Fields
http://advancedcustomfields.com/
867 stars 180 forks source link

Advanced Custom fields is having text domain issues #106

Open latheeshvm opened 5 years ago

latheeshvm commented 5 years ago

`

I have included the the plugin in a theme and above issues where found , Can these be fixed? Also empty alt="" in the plugin file? Thanks

elliotcondon commented 5 years ago

Hi @latheeshvmv

Thanks for the report. Can you please provide the filename and line number for these issues? I have taken a look at the _n() references inside the ACF source code, but can confirm these do contain a valid text domain.

latheeshvm commented 5 years ago

hello @elliotcondon Sorry _n() are false positive, actually that also results in additional min textdomain . to fix that error i had to make some changes , i assigned it to a variable $outfix = $field['min'] ; then placed $outfix. Problem is with the themecheck plugin .


Apply line 794 - inc/fieldgen/acf/includes/admin/admin-field-groups.php


Bulk Actions line 812 - inc/fieldgen/acf/includes/admin/admin-field-groups.php


btn line 38 - inc/fieldgen/acf/includes/admin/views/settings-addons.php


Empty alt = "" 4388 -inc/fieldgen/acf/includes/api/api-helpers.php 134 - inc/fieldgen/acf/includes/fields/class-acf-field-file.php


i couldn't find these , it's really to find out :/ WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments

WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'Apply'

WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments '%s'