search

AdvancedCustomFields / acf

Advanced Custom Fields
http://advancedcustomfields.com/
833 stars 170 forks source link

Moving multiple blocks into innerblock breaks Gutenberg #543

Open justinkruit opened 3 years ago

justinkruit commented 3 years ago

When moving multiple blocks into an innerblock, the whole page breaks.

Here is the error:

TypeError: Cannot read property 'firstChild' of null
    at pp (https://websiteurl.hidden/wp-includes/js/dist/block-editor.min.js?ver=390a9f83b606a55e8b523c4d16bdb08c:12:393446)
    at https://websiteurl.hidden/wp-includes/js/dist/block-editor.min.js?ver=390a9f83b606a55e8b523c4d16bdb08c:12:394426
    at Bh (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:126:456)
    at Dj (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:162:476)
    at unstable_runWithPriority (https://websiteurl.hidden/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)
    at Da (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:60:280)
    at xb (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:162:231)
    at Te (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:146:79)
    at https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:61:68
    at unstable_runWithPriority (https://websiteurl.hidden/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)

And here is a gif of the error: jQ9xkXCyZF

CreativeDive commented 3 years ago

@justinkruit I can confirm this. @mattgrshaw @lgladdy maybe possible to fix this in ACF 5.10.2 ?

mattgrshaw commented 3 years ago

We'll take a look, thanks for the report!

mattgrshaw commented 3 years ago

I was able to replicate this one as well, but it doesn't appear to be a regression with the 5.10x release. Since we're trying to get 5.10.2 out this week, I think this might be something we want to address in 5.11.

CreativeDive commented 3 years ago

thank you @mattgrshaw

justinkruit commented 3 years ago

Thanks! Hope it gets fixed soon.

lgladdy commented 2 years ago

Hey everyone!

We think this is this bug: https://github.com/WordPress/gutenberg/issues/33610 which will require a Gutenberg update to fix I'm afraid!