search

AdvancedPhotonSource / GSAS-II

Home for GSAS-II: crystallographic and diffraction-based structural characterization of materials
Other
29 stars 10 forks source link

Importer calling FabIO #8

Open briantoby opened 6 months ago

briantoby commented 6 months ago

FabIO reads lots of image types that GSAS-II does not. An importer could call FabIO. This requires matching FabIO metadata reporting to the GSAS-II input needs.

briantoby commented 6 months ago

@briantoby: note 3/7/24 e-mail from Siwei Chen

kif commented 2 months ago

If you need a hand ... I could probably help.

briantoby commented 2 months ago

i would love to get some help on this. My thought is that I open a branch for this and outline a new importer. Once I do that, it will be more clear what is needed (which will be to map output from FabIO into places where GSAS-II needs the input.)

I'll try to get to this soon, but it might take a week...

briantoby commented 2 months ago

@kif A week was only a bit optimistic, but I wanted to change the way that Importers report errors for needed packages and provide a mechanism for installing them from the GUI (since I don't think most users can manage conda or pip directly.) Also, I have updated the doc's on how importers are expected to work (https://gsas-ii.readthedocs.io/en/latest/imports.html#writing-an-importer-routine).

In any case, I have created a branch (FabIO) with a shell for a new importer, https://github.com/AdvancedPhotonSource/GSAS-II/blob/FabIO/GSASII/imports/G2img_FabIO.py. If you would be willing to take a stab at filling out that code, it would be very much appreciated. You might want to fork it and create a PR so we can both work on it.