Open carterbox opened 3 years ago
Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
src/tike/pca.py
:Line 133:9: E741 ambiguous variable name 'I' Line 143:5: E301 expected 1 blank line, found 0
src/tike/ptycho/probe.py
:Line 481:47: W605 invalid escape sequence '\s' Line 572:81: E501 line too long (81 > 80 characters)
src/tike/ptycho/ptycho.py
:Line 72:81: E501 line too long (85 > 80 characters)
Purpose
Implementing orthrogonal probe relaxation.
Approach
Instead of a common probe, the probe at each scan position is allowed to be slightly different from the others. This is accomplished by having each probe a weighted average of a unique probe and the first N principal components of all of the probes.
Pre-Merge Checklists
Submitter
yapf
to format python code.Reviewer