AdvancedPhotonSource / tike

Repository for ptychography software
http://tike.readthedocs.io
Other
29 stars 15 forks source link

API: Remove fly-dimension from arrays #108

Closed carterbox closed 3 years ago

carterbox commented 3 years ago

Purpose

Remove the 'fly' dimension from arrays because it is not being used. I plan to replace this dimension with the 'coherent' probe dimension which is necessary for orthogonal probe relaxation.

Approach

Removed the fly-dimension from documentation. Also, improved the tests for ptycho algorithms to provide better feedback by actually saving the results to the disk. By looking at the results, I already squashed a bug where lstsq_grad probe recovery wasn't working correctly.

Pre-Merge Checklists

Submitter

Reviewer