AdvancedPhotonSource / tike

Repository for ptychography software
http://tike.readthedocs.io
Other
29 stars 15 forks source link

NEW: Multi-device multi-probe updates for ptycho.cgrad #122

Closed carterbox closed 3 years ago

carterbox commented 3 years ago

Purpose

Add multi-device probe updates to the ptycho.cgrad method.

Approach

Uses features enabled by the refactoring of the Patch operator to update all probes simultaneously using multiple devices.

Pre-Merge Checklists

Submitter

Reviewer

xiaodong-yu commented 3 years ago

Does this PR use different devices to process different probes? If so, we need to schedule a meeting with Tekin, possibly tomorrow. We need to discuss the priority between the sub-images and the probes in terms of device usage.

carterbox commented 3 years ago

No. It only divides the work along the scan-position-axis. It doesn't make sense to split the probes between different devices because that would probably require synchronizing diffraction patterns between devices.

xiaodong-yu commented 3 years ago

No. It only divides the work along the scan-position-axis. It doesn't make sense to split the probes between different devices because that would probably require synchronizing diffraction patterns between devices.

Then, it's confusing to me what does "update all probes simultaneously using multiple devices" mean?

carterbox commented 3 years ago

When multi-probe is enabled (the number of probes (modes) is greater than 1), each of the these probes is updated simultaneously with the others instead of sequentially.

xiaodong-yu commented 3 years ago

But each device will process all the probes, just with different scans, right?

carterbox commented 3 years ago

That is correct.