API: Implement position correction and position regularization for the lstsq method - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

API: Implement position correction and position regularization for the lstsq method #137

Closed carterbox closed 3 years ago

carterbox commented 3 years ago

Purpose

[x] Implement a position correction for lstsq method as described in the least-squares paper (gradients of patches)
[x] Implement a regularization method for position correction which regularized updated positions based on a position reliability metric.
[ ] Implement adjustable affine position error

Approach

Pre-Merge Checklists

Submitter

[x] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[ ] Document all new functions.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Build the documentation successfully
[ ] Use yapf to format python code.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 3 years ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-07-06 17:34:29 UTC