search

AdvancedPhotonSource / tike

Repository for ptychography software
http://tike.readthedocs.io
Other
29 stars 15 forks source link

CI: Try to save reconstruction results as artifacts #155

Closed carterbox closed 3 years ago

carterbox commented 3 years ago

This PR replaces the ptycho reconstruction tests dataset with a real dataset that has been downsampled to be small enough for the CI. It also now saves these reconstruction results as an 'artifact' on the azure pipelines website. Anyone can now see the actual reconstruction results from the CI by downloading them from the azure pipelines page.

pep8speaks commented 3 years ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-08-04 21:36:31 UTC
carterbox commented 3 years ago

@xiaodong-yu, this updated test has revealed that there is something wrong with the cgrad MPI ptychography reconstruction. Looks like this: 0-phase-7 Any ideas what's wrong? For references, the non-mpi reconstruction looks like this: 0-phase-1

carterbox commented 3 years ago

A change I made to the tests caused the issue with MPI. Using MPI requires a synchronized initial guess for psi which I was not providing.

xiaodong-yu commented 3 years ago

A change I made to the tests caused the issue with MPI. Using MPI requires a synchronized initial guess for psi which I was not providing.

Thank you for solving this issue, @carterbox!