AdvancedPhotonSource / tike

Repository for ptychography software
http://tike.readthedocs.io
Other
29 stars 15 forks source link

API: Make psi parameter of tike.ptycho.reconstruct positional #196

Closed carterbox closed 2 years ago

carterbox commented 2 years ago

Purpose

Realized that the psi parameter is required, but has a default value of None. This is left over from a previous API breaking change where I removed auto-initialization of psi. This fix moves psi to the position parameters, so that the error raised tells the user that psi is required instead of that None has no parameters.

Also, adds a parameter to the velociprobe data loader, so that the data cropping can be controlled by the user.

Pre-Merge Checklists

Submitter

Reviewer

carterbox commented 2 years ago

Open to better ways to handle this API breaking change.