issues
search
AdvancedPhotonSource
/
tike
Repository for ptychography software
http://tike.readthedocs.io
Other
29
stars
15
forks
source link
REF: Use device array instead of two scalars for rescale_probe
#234
Closed
carterbox
closed
1 year ago
carterbox
commented
1 year ago
Because:
Reduces the number of synchronization calls between devices
Allocates memory directly on GPU instead of transferring these two scalars from the host
Reduces number of return parameters to simplify map syntax
Purpose
Approach
Pre-Merge Checklists
Submitter
[ ] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[ ] Document all new functions.
[ ] Click 'details' on the readthedocs check to view the updated docs.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Address any complaints from pep8speaks.
Reviewer
[ ] Actually read all of the code.
[ ] Run the new code yourself; the included tests should make this easy.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.
Because:
Purpose
Approach
Pre-Merge Checklists
Submitter
Reviewer