AdvancedPhotonSource / tike

Repository for ptychography software
http://tike.readthedocs.io
Other
29 stars 15 forks source link

API: Refactor Comm, MPIComm, ThreadPool #248

Closed carterbox closed 1 year ago

carterbox commented 1 year ago

Purpose

Refactor the communicator classes to be more consistent with each other (MPI and Threads equivalent operations have the same arguments) and remove if use_mpi statements for easier to read workflows.

Approach

Add tests for all of the MPI and Pool methods. Use only MPI-inclusive communicator patterns from Comm, and use a placeholder MPI when MPI is not available.

Pre-Merge Checklists

Submitter

Reviewer