Closed a4894z closed 8 months ago
Hello @a4894z! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
src/tike/ptycho/probe.py
:Line 142:78: W291 trailing whitespace Line 146:63: E201 whitespace after '(' Line 146:72: E202 whitespace before ')' Line 147:81: E501 line too long (85 > 80 characters) Line 205:66: W291 trailing whitespace
src/tike/ptycho/ptycho.py
:Line 446:40: E251 unexpected spaces around keyword / parameter equals Line 446:42: E251 unexpected spaces around keyword / parameter equals Line 446:81: E501 line too long (98 > 80 characters)
I thought automerge would wait until the tests pass. Oops!
This doesn't fix the underlying cause of these hot spots but this should cure the symptoms of the underlying disease for the time being
Purpose
Sometimes we see these strange "hot spots" in the shared probe modes; we are still unsure of the underlying cause of these hot spots but use of a median filter seems to be effective of removing them when do occur.
Approach
I introduce a function that simply takes the absolute value of the shared probe modes, and applies a median filter to each mode. The width of the median window is specified in the .toml file; alternatively we default to NOT using any median filtering.
Pre-Merge Checklists
Submitter
Reviewer