BUG: Use syntax compatible with python 3.9/3.8 - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

BUG: Use syntax compatible with python 3.9/3.8 #301

Closed carterbox closed 8 months ago

carterbox commented 8 months ago

Purpose

Fix some syntax that is incompatible with older python versions.

Approach

Using typing.Optional and typing.Union instead of |

Pre-Merge Checklists

Submitter

[ ] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[ ] Document all new functions.
[ ] Click 'details' on the readthedocs check to view the updated docs.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Address any complaints from pep8speaks.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself; the included tests should make this easy.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 8 months ago

Hello @carterbox! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tike/view.py:

Line 679:81: E501 line too long (87 > 80 characters)